Add utility command to get the launch command length #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
yaohaizh
reviewed
Feb 18, 2019
| */ | ||
| public static Path generateArgfile(String[] classPaths, String[] modulePaths) throws IOException { | ||
| String argfile = ""; | ||
| if (ArrayUtils.isNotEmpty(classPaths)) { |
Contributor
There was a problem hiding this comment.
Is the path separate cross-platform safety?
Contributor
Author
There was a problem hiding this comment.
do you mean File.pathSeparator? it's platform dependent.
Contributor
There was a problem hiding this comment.
Yes, lots of hard code with path manipulation. Should aware of platform for path operations.
yaohaizh
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
Reference the PR microsoft/vscode-java-debug#532 for the usage.