Provide jarmanifest/argfile approachs to shorten the command line #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
testforstephen
requested review from
Eskibear,
akaroml,
andxu and
yaohaizh
and removed request for
Eskibear
Eskibear
reviewed
Feb 15, 2019
...microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/protocol/Requests.java
Outdated
Show resolved
Hide resolved
Eskibear
reviewed
Feb 15, 2019
...microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/protocol/Requests.java
Outdated
Show resolved
Hide resolved
Eskibear
reviewed
Feb 15, 2019
...rosoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/DebugAdapter.java
Show resolved
Hide resolved
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
akaroml
reviewed
Feb 15, 2019
| } | ||
|
|
||
| try { | ||
| Thread.sleep(1000); |
|
|
||
| activeLaunchHandler.preLaunch(launchArguments, context); | ||
|
|
||
| Path tempfile = null; |
Member
There was a problem hiding this comment.
The body of this function is already long. Please refactor by putting the procedures of generating Jar Manifest and ArgFile into different utility functions. Those functions should be functional without referencing states from other parts. After that the body looks like:
if (launchArguments.shortenCommandLine == ShortenApproach.JARMANIFEST) {
Path path = AdapterUtils.generateClasspathJar(...);
context.setClasspathJar(path);
} else if (...) {
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
Fix the bug microsoft/vscode-java-debug#110.
Provide two kinds of approaches jarmanifest and argfile to shorten the command line length.