Repository navigation
fix the bug: Cannot run from src/test anymore bug #413 - #232
Merged
Merged
Conversation
Andy Xu(devdiv) (andxu)
requested review from
Jinbo Wang (testforstephen) and
Yaohai Zheng (yaohaizh)
and removed request for
Jinbo Wang (testforstephen)
September 26, 2018 08:53
Jinbo Wang (testforstephen)
requested changes
Sep 26, 2018
| * @param classpathEntry classpath entry | ||
| * @return whether this classpath entry is only used in test | ||
| */ | ||
| private static boolean forTestOnly(final IClasspathEntry classpathEntry) { |
Contributor
There was a problem hiding this comment.
forTestOnly -> isTest
| } | ||
| } | ||
| } | ||
| } catch (JavaModelException e) { |
Contributor
There was a problem hiding this comment.
extract the logic to a function getTestFolders(IJavaProject project).
| if (!testFolders.isEmpty()) { | ||
| try { | ||
|
|
||
| List<Object> mainClassesInTestFolder = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
boolean isFound = false;
Contributor
Author
There was a problem hiding this comment.
I cannot change the value isFound at the callback
| public void acceptSearchMatch(SearchMatch match) { | ||
| Object element = match.getElement(); | ||
| if (element instanceof IJavaElement) { | ||
| mainClassesInTestFolder.add(element); |
Contributor
There was a problem hiding this comment.
isFound = true;
Jinbo Wang (testforstephen)
approved these changes
Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.