Repository navigation
Don't repeat to report compile errors for logpoints and conditional bp - #224
Merged
Merged
Conversation
Andy Xu(devdiv) (andxu)
requested a review
from Jinbo Wang (testforstephen)
September 10, 2018 01:15
Jinbo Wang (testforstephen)
requested changes
Sep 10, 2018
| if (!firstTime && breakpoint != null) { | ||
| if (StringUtils.isNotBlank(breakpoint.getLogMessage())) { | ||
| // for logpoint with compilation errors, don't send errors if it is already reported | ||
| completableFuture.complete(debugTarget.getVM().mirrorOf("")); |
Contributor
There was a problem hiding this comment.
IValue emptyStringValue = debugTarget.getVM().mirrorOf("");
completableFuture.complete(emptyStringValue);
Contributor
Author
There was a problem hiding this comment.
changed
| completableFuture.complete(debugTarget.getVM().mirrorOf("")); | ||
| } else { | ||
| // for conditional bp, report true to let breakpoint hit | ||
| completableFuture.complete(debugTarget.getVM().mirrorOf(true)); |
Contributor
There was a problem hiding this comment.
IValue booleanValue = debugTarget.getVM().mirrorOf(true);
completableFuture.complete(booleanValue);
Contributor
Author
There was a problem hiding this comment.
changed
Jinbo Wang (testforstephen)
approved these changes
Sep 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.