Skip to content

Remove duplicate classpath #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andy Xu(devdiv) (andxu) merged 10 commits into from
Sep 7, 2018
Merged

Remove duplicate classpath #223

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1a156d9
1. record sum of responding time for the debug session
andxu Aug 28, 2018
cfc7920
aaa
andxu Aug 29, 2018
8131ffe
Merge branch 'master' of https://github.com/Microsoft/java-debug
andxu Aug 29, 2018
8afdf39
Merge branch 'master' of https://github.com/Microsoft/java-debug
andxu Aug 30, 2018
f3ae6ef
Merge branch 'master' of https://github.com/Microsoft/java-debug
andxu Sep 5, 2018
86ccda1
Merge branch 'master' of https://github.com/Microsoft/java-debug
andxu Sep 7, 2018
90703a0
Remove duplicate classpath.
andxu Sep 7, 2018
fa8f706
Fix checkstyle issue.
andxu Sep 7, 2018
01b5c57
use LinkedHashSet to check duplicate and keep the order.
andxu Sep 7, 2018
868aba9
remove un-expected changes.
andxu Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ugin/src/main/java/com/microsoft/java/debug/plugin/internal/ResolveClasspathsHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
package com.microsoft.java.debug.plugin.internal;

import java.util.ArrayList;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Set;
import java.util.logging.Level;
import java.util.logging.Logger;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -177,7 +179,7 @@ private static String[][] computeClassPath(IJavaProject javaProject) throws Core

private static String[] computeDefaultRuntimeClassPath(IJavaProject jproject) throws CoreException {
IRuntimeClasspathEntry[] unresolved = JavaRuntime.computeUnresolvedRuntimeClasspath(jproject);
List<String> resolved = new ArrayList<>(unresolved.length);
Set<String> resolved = new LinkedHashSet<String>();
for (int i = 0; i < unresolved.length; i++) {
IRuntimeClasspathEntry entry = unresolved[i];
if (entry.getClasspathProperty() == IRuntimeClasspathEntry.USER_CLASSES) {
Expand All @@ -189,6 +191,7 @@ private static String[] computeDefaultRuntimeClassPath(IJavaProject jproject) th
}
String location = entries[j].getLocation();
if (location != null) {
// remove duplicate classpath
resolved.add(location);
}
}
Expand Down