Fix issue #402 missing runtime scope classpath entry #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maven.pomderived=true test=true maven.groupId=org.yaml maven.artifactId=snakeyaml maven.version=1.19 maven.scope=runtime
Contributor
Author
fbricon
reviewed
Sep 6, 2018
|
|
||
| private static boolean isRuntime(final IClasspathEntry classpathEntry) { | ||
| for (IClasspathAttribute attribute : classpathEntry.getExtraAttributes()) { | ||
| if (IClasspathManager.SCOPE_ATTRIBUTE.equals(attribute.getName()) && "runtime".equals(attribute.getValue())) { |
Collaborator
There was a problem hiding this comment.
I would not add a dependency to m2e.jdt just for that attribute. I suggest you copy the value directly here
fbricon
reviewed
Sep 6, 2018
| for (int j = 0; j < entries.length; j++) { | ||
|
|
||
| if (entries[j].getClasspathEntry().isTest()) { | ||
| if (entries[j].getClasspathEntry().isTest() && !isRuntime(entries[j].getClasspathEntry())) { |
Collaborator
There was a problem hiding this comment.
I believe you should always add runtime classes, regardless of their "test" attribute
it's fine
Contributor
Author
|
Moved to the hotfix PR, #219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maven.pomderived=true
test=true
maven.groupId=org.yaml
maven.artifactId=snakeyaml
maven.version=1.19
maven.scope=runtime