Repository navigation
fix #111: Should not include test classes in classpaths - #202
Merged
Merged
Conversation
…olve maven project
Andy Xu(devdiv) (andxu)
requested review from
Rome Li (akaroml),
Xuan Zhou (ansyral),
Jinbo Wang (testforstephen) and
Yaohai Zheng (yaohaizh)
August 13, 2018 01:08
Contributor
Author
Yaohai Zheng (yaohaizh)
suggested changes
Aug 13, 2018
Yaohai Zheng (yaohaizh)
left a comment
Yaohai Zheng (yaohaizh)
left a comment
Contributor
There was a problem hiding this comment.
Use the existing API
| if (entry.getClasspathProperty() == IRuntimeClasspathEntry.USER_CLASSES) { | ||
| IRuntimeClasspathEntry[] entries = JavaRuntime.resolveRuntimeClasspathEntry(entry, jproject); | ||
| for (int j = 0; j < entries.length; j++) { | ||
|
|
Contributor
There was a problem hiding this comment.
Please use the existing API:
IClasspathEntry.isTest()
Contributor
Author
There was a problem hiding this comment.
Nicer to use isTest since photon is added to pom.xml, fixed.
Yaohai Zheng (yaohaizh)
approved these changes
Aug 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.