Repository navigation
Support logpoint feature for java debugger - #184
Merged
Merged
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Jinbo Wang (testforstephen)
requested review from
Rome Li (akaroml),
Andy Xu(devdiv) (andxu) and
Yaohai Zheng (yaohaizh)
June 21, 2018 07:40
| */ | ||
| CompletableFuture<Value> evaluateForBreakpoint(IBreakpoint breakpoint, ThreadReference thread, Map<IBreakpoint, Object> breakpointExpressionMap); | ||
|
|
||
| CompletableFuture<Value> evaluateForLogpoint(IBreakpoint breakpoint, ThreadReference thread, Map<IBreakpoint, Object> breakpointExpressionMap); |
Contributor
There was a problem hiding this comment.
The design here is weird. You have already designed the interface of IBreakpoint for both types, yet provide two API on IEvaludationProvider, which is contradict to the interface usage.
| } | ||
|
|
||
| // find the breakpoint related to this breakpoint event | ||
| IBreakpoint conditionalBP = Arrays.asList(manager.getBreakpoints()).stream().filter(bp -> StringUtils.isNotBlank(bp.getCondition()) |
Contributor
There was a problem hiding this comment.
Please improve the logic here. The method is lengthy.
Contributor
Author
There was a problem hiding this comment.
fixed.
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Andy Xu(devdiv) (andxu)
approved these changes
Jun 22, 2018
Yaohai Zheng (yaohaizh)
approved these changes
Jun 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com