Skip to content

AttachRequestHandler should record error of attach failures. #59

Closed

Description

AttachRequestHandler.java
try {
logger.info(String.format("Trying to attach to remote debuggee VM %s:%d .",
attachArguments.hostName, attachArguments.port));
IDebugSession debugSession = DebugUtility.attach(vmProvider.getVirtualMachineManager(),
attachArguments.hostName, attachArguments.port, attachArguments.timeout);
context.setDebugSession(debugSession);
logger.info("Attaching to debuggee VM succeeded.");
} catch (IOException | IllegalConnectorArgumentsException e) {
AdapterUtils.setErrorResponse(response, ErrorCode.ATTACH_FAILURE,
String.format("Failed to attach to remote debuggee VM. Reason: %s", e.toString()));
}

Activity

  1. added this to the 0.2.0 milestone on Sep 29, 2017
  2. yaohaizh commented on Oct 9, 2017

    @yaohaizh
    Contributor

    Andy Xu(devdiv) (@andxu), please update the status of this issue.

  3. andxu commented on Oct 9, 2017

    @andxu
    ContributorAuthor
  4. andxu commented on Dec 7, 2017

    @andxu
    ContributorAuthor

    Done with the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions