Skip to content

Build failure: TypeFilter cannot be resolved to a type #534

Closed

Description

@bsolar17

I'm trying to build on MacOS and I'm having the following compilation failure:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:4.0.3:compile (default-compile) on project com.microsoft.java.debug.plugin: Compilation failure: Compilation failure:
[ERROR] /Users/bsolar/Projects/java-debug/com.microsoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/CompletionProposalRequestor.java:[324]
[ERROR]         return declaringType != null && org.eclipse.jdt.ls.core.internal.contentassist.TypeFilter.isFiltered(declaringType);
[ERROR]                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] org.eclipse.jdt.ls.core.internal.contentassist.TypeFilter cannot be resolved to a type
[ERROR] 1 problem (1 error)

Activity

  1. RedyCtl commented on Feb 4, 2024

    @RedyCtl

    Same problem

  2. Libadoxon commented on Feb 5, 2024

    @Libadoxon

    Same on Linux, from want I can tell this is caused by a dependency change. Though then one has to ask themselves why the dependencies are not pinned to ensure reproducibility. This shouldn't be too much of a hassle but I'm not a Java dev so I might be wrong there. As a workaround you can comment of the right side of the if condition, so that the code looks like that:

    return declaringType != null /*&& org.eclipse.jdt.ls.core.internal.contentassist.TypeFilter.isFiltered(declaringType)*/;

    This at least allows the package to build but probable unfixes the issues mentioned in the code (Jdtls 1212)

  3. bsolar17 commented on Feb 5, 2024

    @bsolar17
    ContributorAuthor

    Though then one has to ask themselves why the dependencies are not pinned to ensure reproducibility. This shouldn't be too much of a hassle but I'm not a Java dev so I might be wrong there.

    I think this is due to this file. E.g:

    <unit id="org.eclipse.jdt.source.feature.group" version="0.0.0"/>
    

    My understanding is that version="0.0.0" means "use the latest version", which of course is not reproducible.

  4. Libadoxon commented on Feb 5, 2024

    @Libadoxon

    My understanding is that version="0.0.0" means "use the latest version", which of course is not reproducible.

    You're probable right, hope that this changes. While I can of course understand that that would create extra work, I still think its very important for a version to always build. A compromise maybe would be to only pin the dependencies for every release to ensure at least reproducibility there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions