Skip to content

[performance] should break out the while loop #279

New issue
New issue
Closed
Closed
[performance] should break out the while loop#279
Labels
bug

Description

@tom-shan
tom-shan
opened on Jun 12, 2019

https://github.com/microsoft/java-debug/blob/master/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/AbstractDisconnectRequestHandler.java#L73-L94
Now it will costs about 5 seconds in the destroyLaunchFiles function, maybe there should have a break statement if no IOException catched in each loop for better performance.

Activity

  1. testforstephen commented on Jun 12, 2019

    @testforstephen
    Jinbo Wang (testforstephen)
    on Jun 12, 2019
    Contributor

    nice finding.

  2. Jinbo Wang (testforstephen)
    added
    bug
    on Jun 12, 2019

  3. testforstephen commented on Jun 12, 2019

    @testforstephen
    Jinbo Wang (testforstephen)
    on Jun 12, 2019
    Contributor

    tom-shan Could you help make a pull request?

  4. Jinbo Wang (testforstephen)
    closed this as completedon Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions