SummarizeExtractor no longer crashes indexing for rejected LLM calls#2201
Open
neaorin wants to merge 1 commit intomicrosoft:mainfrom
Open
SummarizeExtractor no longer crashes indexing for rejected LLM calls#2201neaorin wants to merge 1 commit intomicrosoft:mainfrom
neaorin wants to merge 1 commit intomicrosoft:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SummarizeExtractor would crash the entire indexing workflow for certain rejected LLM calls, like Azure content filtering issues (see #870). This is a major issue when indexing large datasets, if your input includes some explicit or violent content etc.
This PR implements the same try/catch approach used by the GraphExtractor to return an empty summarization, so indexing can continue.
Related Issues
#870
Proposed Changes
Implement a try/catch on SummarizeExtractor, so indexing doesn't stop in case of a rejected LLM call.
Checklist
Additional Notes
none