Repository navigation
Centralize development dependencies in pyproject.toml groups - #334
Conversation
Share test tooling between Nox and the official pipeline while preserving runtime dependency resolution from built wheels. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the consolidation of development and CI tooling into shared dependency groups.
No open issues 🎉
What changed in this PR
Centralizes development and CI tooling in root pyproject.toml dependency groups, reducing dependency drift between local checks and the official build. Runtime dependencies remain in package metadata and are resolved from built wheels in official CI.
Changes:
- Adds focused tooling groups and an aggregate
devgroup, replacing root requirements files. - Updates Nox, GitHub Actions, the official pipeline, and Makefile to use groups with pip 25.1 or later.
- Updates contributor documentation while leaving sample and Function app requirements unchanged.
| File | Description |
|---|---|
requirements.txt |
Removes the legacy development dependency list. |
pyproject.toml |
Defines shared development and CI dependency groups. |
noxfile.py |
Installs session tooling through shared groups. |
Makefile |
Uses the dev group and editable package installs. |
eng/templates/build.yml |
Uses shared build, lint, and test groups while preserving wheel-based runtime validation. |
docs/development.md |
Documents group-based setup and dependency ownership. |
dev-requirements.txt |
Removes the legacy tooling dependency list. |
.github/workflows/typecheck.yml |
Installs Nox through its dependency group. |
.github/workflows/durabletask.yml |
Updates core CI to group-based Nox installation. |
.github/workflows/durabletask-azuremanaged.yml |
Updates Azure Managed CI to group-based Nox installation. |
.github/workflows/durabletask-azurefunctions.yml |
Updates Functions CI to group-based Nox installation. |
.github/copilot-instructions.md |
Updates tooling installation guidance and dependency references. |
Review effort: Balanced
Resolve shared groups through nox.project helpers instead of upgrading pip in each session. Require the Nox release that introduced the group helper. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Bernd Verst (berndverst)
left a comment
There was a problem hiding this comment.
This accomplishes the dependency-centralization goal and is a net improvement: Nox and the official build now share tooling groups, while runtime dependencies remain declared by the packages and exercised through built wheels. I found no actionable introduced defects, runtime performance regression, or public API/package compatibility break. The pip >=25.1 developer-workflow migration is documented, the declared minimum Nox version supports the resolver, and existing Python minimums are preserved. I verified the documented editable setup with pip 25.1/Nox 2025.2.9 in an isolated environment and ran 302 focused unit tests successfully. The PEP 735 approach is appropriate modern Python packaging; no additional Python 3.10-specific rewrite is warranted.
Resolve the Nox lint conflict using the shared lint group, and migrate main's new Ruff requirement before retaining removal of dev-requirements.txt. Preserve upstream modernization, warning, and E2E isolation updates. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Bernd Verst (berndverst)
left a comment
There was a problem hiding this comment.
Re-reviewed ed08b09 after the merge from main. The reconciliation preserves the dependency-group migration and correctly carries Ruff into the shared lint group, while retaining Ruff execution, deprecation guardrails, and per-host Functions isolation. I found no actionable introduced defects or runtime/API compatibility regressions. The resolved Nox lint session passes both Flake8 and Ruff, and the 19 focused host-isolation/log-framing tests pass. This remains a net-positive tooling cleanup; existing package Python minimums are unchanged.
Summary
Move repository development and CI tooling from the root requirements files and hard-coded install lists into PEP 735
[dependency-groups]in the rootpyproject.toml.testgroup between Nox sessions and the official build so new test dependencies do not require a separate pipeline update.devgroup.Runtime dependencies and public extras remain in package metadata. The official build continues to resolve SDK runtime dependencies from built wheels rather than a preinstalled development environment. Sample and Function app requirements files remain unchanged.
Relates to #333.