Repository navigation
Fix Azure Functions E2E log framing and host isolation - #332
Conversation
Split concatenated timestamped records before returning matched host output, preserving strict logging assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Give each FunctionApp its own stable task hub instead of sharing the Nox session hub, and verify rewind starts from the intended activity failure. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the test-infrastructure changes targeting host-log parsing and task-hub isolation.
No open issues 🎉
What changed in this PR
This PR addresses Azure Functions E2E flakes from adjacent host log records and sample hosts sharing a task hub. Changes are limited to test infrastructure and coverage; SDK behavior, retry policies, and timeouts remain unchanged.
Changes:
- Extract timestamp-delimited host log records while preserving exact message assertions and category-filter coverage.
- Assign each sample host its own task hub instead of sharing one across the Nox session.
- Add host-free regression tests and require the rewind test’s initial failure to contain the deliberate activity error.
| File | Description |
|---|---|
tests/azure-functions-durable/e2e/test_v1_client_e2e.py |
Verify the expected initial rewind failure and correct the module docstring. |
tests/azure-functions-durable/e2e/test_host_log_records.py |
Cover adjacent log records and preservation of nonmatching output. |
tests/azure-functions-durable/e2e/test_host_isolation.py |
Verify unique, stable task hubs without modifying the parent environment. |
tests/azure-functions-durable/e2e/_harness.py |
Add per-host task hubs and timestamp-based log record extraction. |
noxfile.py |
Remove the session-wide shared task hub setting. |
Review effort: Balanced
Bernd Verst (berndverst)
left a comment
There was a problem hiding this comment.
Reviewed 9a5f881 against main (f9f754c). No defects found. This is a net-positive test-infrastructure fix: timestamp-based extraction preserves the exact host-routing and category-filter assertions, while per-host task hubs prevent sample apps from consuming each other's orchestration work. The rewind precondition also verifies the intended failure. I found no material performance degradation, public breaking change, or inappropriate Python compatibility/style change. The 19 new host-free cases passed locally, and both strict-typing E2E CI jobs are green. Full E2E was not rerun locally because Azurite and the isolated sample environments were not provisioned.
Summary
dtask_styleconsumedv1_style'srewind_targetbeforefail_onceran; the accepted rewind was then followed by the activity's first real failure.These changes are confined to E2E infrastructure and tests; no SDK behavior, retry policy, or timeouts change.
Fixes #330.
Fixes #331.