Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/durabletask-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: microsoft/durabletask-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: wangbill/resolve-todo-comments
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Feb 27, 2026

  1. Fix compute_next_delay returning None when max_retry_interval is not set 

    The compute_next_delay() method in RetryableTask had a bug where the
return statement for the computed delay was inside the
'if max_retry_interval is not None' block. When max_retry_interval was
not set (the default), the method would fall through and return None,
causing retries to silently not happen.

This fix moves the return statement outside the max_retry_interval
check so the delay is always returned after optional capping.

Added two new tests:
- test_activity_retry_without_max_retry_interval: verifies retry with
  exponential backoff works when max_retry_interval is not set
- test_activity_retry_with_default_backoff: verifies retry with default
  backoff_coefficient (1.0) produces constant delays
    @YunchuWang
    YunchuWang committed Feb 27, 2026
    Configuration menu
    Copy the full SHA
    c172c81 View commit details
    Browse the repository at this point in the history

  2. Resolve TODO comments for unexpected event warnings 

    Replace 5 'TODO: Should this be an error?' comments with descriptive
explanations noting these can happen during replay or duplicate event
delivery. The warning logs are already correctly implemented for all
event types (timerFired, taskCompleted, taskFailed,
subOrchestrationInstanceCompleted, subOrchestrationInstanceFailed).
    @YunchuWang
    YunchuWang committed Feb 27, 2026
    Configuration menu
    Copy the full SHA
    1ec4249 View commit details
    Browse the repository at this point in the history
Loading