Skip to content

Fixing gRPC channel shutdown #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophiatev merged 1 commit into from
Dec 16, 2025
Merged

Fixing gRPC channel shutdown #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,16 @@ public final class DurableTaskGrpcClient extends DurableTaskClient {
public void close() {
if (this.managedSidecarChannel != null) {
try {
this.managedSidecarChannel.shutdown().awaitTermination(5, TimeUnit.SECONDS);
if (!this.managedSidecarChannel.shutdown().awaitTermination(5, TimeUnit.SECONDS))
{
this.managedSidecarChannel.shutdownNow();
}
} catch (InterruptedException e) {
// Best effort. Also note that AutoClose documentation recommends NOT having
// close() methods throw InterruptedException:
// https://docs.oracle.com/javase/7/docs/api/java/lang/AutoCloseable.html
this.managedSidecarChannel.shutdownNow();
Thread.currentThread().interrupt();
}
}
}
Expand Down
Loading