Skip to content

Conversation

@halspang
Copy link
Member

The integration tests were using a retry extension that was eating exceptions and hiding failures. This commit updates the extension to retry and still report failed tests.

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@halspang halspang requested a review from a team as a code owner May 22, 2025 23:16
YunchuWang
YunchuWang previously approved these changes May 22, 2025
The integration tests were using a retry extension that was
eating exceptions and hiding failures. This commit updates
the extension to retry and still report failed tests.

Signed-off-by: Hal Spang <halspang@microsoft.com>
Signed-off-by: Hal Spang <halspang@microsoft.com>
@halspang halspang force-pushed the halspang/fix_test_retry branch from 08c5491 to e89e1dd Compare June 4, 2025 21:01
Signed-off-by: Hal Spang <halspang@microsoft.com>
@halspang halspang merged commit 140f934 into main Jun 5, 2025
4 checks passed
@halspang halspang deleted the halspang/fix_test_retry branch June 5, 2025 22:07
javier-aliaga pushed a commit to javier-aliaga/durabletask-java that referenced this pull request Jun 19, 2025
* Fix integration test retry extension

The integration tests were using a retry extension that was
eating exceptions and hiding failures. This commit removes
the customer extension and relies on gradle's built in retry.

Signed-off-by: Hal Spang <halspang@microsoft.com>
javier-aliaga pushed a commit to javier-aliaga/durabletask-java that referenced this pull request Jul 1, 2025
* Fix integration test retry extension

The integration tests were using a retry extension that was
eating exceptions and hiding failures. This commit removes
the customer extension and relies on gradle's built in retry.

Signed-off-by: Hal Spang <halspang@microsoft.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga pushed a commit to javier-aliaga/durabletask-java that referenced this pull request Jul 1, 2025
* Fix integration test retry extension

The integration tests were using a retry extension that was
eating exceptions and hiding failures. This commit removes
the customer extension and relies on gradle's built in retry.

Signed-off-by: Hal Spang <halspang@microsoft.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga pushed a commit to javier-aliaga/durabletask-java that referenced this pull request Jul 4, 2025
* Fix integration test retry extension

The integration tests were using a retry extension that was
eating exceptions and hiding failures. This commit removes
the customer extension and relies on gradle's built in retry.

Signed-off-by: Hal Spang <halspang@microsoft.com>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants