Skip to content

Conversation

@YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Apr 25, 2025

This pull request updates the protobuf definitions and associated metadata in the internal/durabletask-protobuf package. The changes include adding a new import, updating the commit hash for the protobuf source, and introducing a new field to the OrchestratorRequest message.

Protobuf Updates:

  • Updated protobuf source commit hash: The PROTO_SOURCE_COMMIT_HASH file was updated to reflect a new commit (fbe5bb20835678099fc51a44993ed9b045dee5a6), indicating changes in the protobuf source.

  • New import added: The orchestrator_service.proto file now includes google/protobuf/struct.proto, likely to support new functionality.

  • New field in OrchestratorRequest: A properties field of type map<string, google.protobuf.Value> was added to the OrchestratorRequest message, enabling key-value pairs to be included in requests.

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@YunchuWang YunchuWang requested a review from berndverst April 25, 2025 23:38
Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berndverst berndverst merged commit 7fcd449 into main Apr 25, 2025
4 checks passed
@berndverst berndverst deleted the wangbill/pp branch April 25, 2025 23:39
JoshVanL pushed a commit to JoshVanL/durabletask-java that referenced this pull request May 7, 2025
…Request and update source commit hash (microsoft#214)

* Update protobuf definitions to include new properties in OrchestratorRequest and update source commit hash

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants