DTS Support #201

YunchuWang · 2025-01-23T06:18:15Z

Two new azuremanaged packages for connecting to durable task schedulers.
This pull request introduces several significant changes to the azuremanaged project, including new build configurations, client extensions, and options for the Durable Task Scheduler. The most important changes are summarized below:

Build Configuration Updates:

Added a new allprojects configuration to set the group and version for all projects in azuremanaged/build.gradle.
Introduced a new build file for the client module with necessary plugins, dependencies, and publishing configurations in azuremanaged/client/build.gradle.
Added a new build file for the shared module with required plugins and dependencies in azuremanaged/shared/build.gradle.
Updated the settings to include new modules (client, worker, shared) in azuremanaged/settings.gradle.

Client Extensions:

Created DurableTaskSchedulerClientExtensions class to provide extension methods for creating and configuring DurableTaskClient instances.

Client Options:

Added DurableTaskSchedulerClientOptions class to handle configuration options for the Durable Task Scheduler, including methods for creating gRPC channels and handling authentication.

Token Management:

Implemented AccessTokenCache class to cache access tokens for Azure authentication, ensuring tokens are refreshed before expiration.

Workflow Adjustment:

Modified the build validation workflow to remove the -x sign flag from the publishToMavenLocal task in .github/workflows/build-validation.yml.

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

My changes do not require documentation changes
- Otherwise: Documentation issue linked to PR
My changes are added to the CHANGELOG.md
I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

cgillum · 2025-01-23T16:01:19Z

In DTS and Python repos, we changed the build process to instead copy the proto definitions locally rather than rely on a submodule. It's nice because working with submodules can be complicated and hard to track with source control. Should we do the same thing here?

YunchuWang · 2025-01-23T18:49:00Z

Running sample working:
client curl

sample logs:
2025-01-23 10:38:38.879 INFO 7760 2025-01-23 10:38:39.621 DEBUG 7760 --- [ 2025-01-23 10:38:39.621 DEBUG 7760 --- [ 2025-01-23 10:38:39.705 DEBUG 7760 --- [ 2025-01-23 10:39:09.701 WARN 7760 --- [ 2025-01-23 10:39:39.709 WARN 7760 --- [ 2025-01-23 10:40:09.707 WARN 7760 --- [ 2025-01-23 10:40:39.708 WARN 7760 --- [ 2025-01-23 10:41:09.720 WARN 7760 --- [ 2025-01-23 10:41:39.717 WARN 7760 --- [ 2025-01-23 10:41:44.814 INFO 7760 2025-01-23 10:41:44.814 INFO 7760 2025-01-23 10:41:44.814 INFO 7760 2025-01-23 10:41:45.275 DEBUG 7760 --- [ 2025-01-23 10:41:45.275 DEBUG 7760 --- [ 2025-01-23 10:41:45.362 DEBUG 7760 --- [ 2025-01-23 10:42:15.365 WARN 7760 --- [ 2025-01-23 10:42:16.000 DEBUG 7760 --- [ 2025-01-23 10:42:16.000 DEBUG 7760 --- [ 2025-01-23 10:42:16.059 DEBUG 7760 --- [ 2025-01-23 10:42:16.059 DEBUG 7760 --- [ 2025-01-23 10:42:16.059 DEBUG 7760 --- [ 2025-01-23 10:42:17.128 DEBUG 7760 --- [ 2025-01-23 10:42:17.129 DEBUG 7760 --- [ 2025-01-23 10:42:17.129 DEBUG 7760 --- [ 2025-01-23 10:42:18.187 DEBUG 7760 --- [ --- [global-thread-0] c.azure.identity.ChainedTokenCredential : Azure Identity => Attempted credential AzureCliCredential returns a token
Thread-1] com.microsoft.durabletask : a99035b4-2a2a-4324-b0e4-28db2866abd2: calling activity 'ValidateOrder' (#0) with serialized input: "'{orderId:123,"
Thread-1] com.microsoft.durabletask : The orchestrator has yielded and will await for new events.
Thread-1] com.microsoft.durabletask : a99035b4-2a2a-4324-b0e4-28db2866abd2: Activity 'ValidateOrder' (#0) completed with serialized output: false
Thread-1] com.microsoft.durabletask : Received and dropped an unknown {0} work-item from the sidecar.
Thread-1] com.microsoft.durabletask : Received and dropped an unknown {0} work-item from the sidecar.
Thread-1] com.microsoft.durabletask : Received and dropped an unknown {0} work-item from the sidecar.
Thread-1] com.microsoft.durabletask : Received and dropped an unknown {0} work-item from the sidecar.
Thread-1] com.microsoft.durabletask : Received and dropped an unknown {0} work-item from the sidecar.
Thread-1] com.microsoft.durabletask : Received and dropped an unknown {0} work-item from the sidecar.
--- [nio-8080-exec-1] o.a.c.c.C.[Tomcat].[localhost].[/] : Initializing Spring DispatcherServlet 'dispatcherServlet'
--- [nio-8080-exec-1] o.s.web.servlet.DispatcherServlet : Initializing Servlet 'dispatcherServlet'
--- [nio-8080-exec-1] o.s.web.servlet.DispatcherServlet : Completed initialization in 0 ms
Thread-1] com.microsoft.durabletask : 740edaa7-2483-4933-bd6f-c064e431d9d6: calling activity 'ValidateOrder' (#0) with serialized input: "'{orderId:123,"
Thread-1] com.microsoft.durabletask : The orchestrator has yielded and will await for new events.
Thread-1] com.microsoft.durabletask : 740edaa7-2483-4933-bd6f-c064e431d9d6: Activity 'ValidateOrder' (#0) completed with serialized output: false
Thread-1] com.microsoft.durabletask : Received and dropped an unknown {0} work-item from the sidecar.
Thread-1] com.microsoft.durabletask : 06be66ce-ede9-46ea-b6a0-d305cc304bcd: calling activity 'ValidateOrder' (#0) with serialized input: "{"orderId":"123", "amount":100}"
Thread-1] com.microsoft.durabletask : The orchestrator has yielded and will await for new events.
Thread-1] com.microsoft.durabletask : 06be66ce-ede9-46ea-b6a0-d305cc304bcd: Activity 'ValidateOrder' (#0) completed with serialized output: true
Thread-1] com.microsoft.durabletask : 06be66ce-ede9-46ea-b6a0-d305cc304bcd: calling activity 'ProcessPayment' (#1) with serialized input: "{"orderId":"123", "amount":100}"
Thread-1] com.microsoft.durabletask : The orchestrator has yielded and will await for new events.
Thread-1] com.microsoft.durabletask : 06be66ce-ede9-46ea-b6a0-d305cc304bcd: Activity 'ProcessPayment' (#1) completed with serialized output: "{"success":true, "transactionId":"TXN1737657737098"}"
Thread-1] com.microsoft.durabletask : 06be66ce-ede9-46ea-b6a0-d305cc304bcd: calling activity 'ShipOrder' (#2) with serialized input: "{"orderId":"123", "amount":100}"
Thread-1] com.microsoft.durabletask : The orchestrator has yielded and will await for new events.
Thread-1] com.microsoft.durabletask : 06be66ce-ede9-46ea-b6a0-d305cc304bcd: Activity 'ShipOrder' (#2) completed with serialized output: "{"trackingNumber":"TRACK1737657738154"}"

dashboard showing result:

cgillum

I'm wondering if we can refactor this a bit, so that the only new package we ship is an azureManaged package.

client/src/main/java/com/microsoft/durabletask/AccessTokenCache.java

client/build.gradle

internal/durabletask-protobuf/lib/java/build.gradle

internal/durabletask-protobuf/README.md

internal/durabletask-protobuf/LICENSE

CHANGELOG.md

cgillum

This is great. Thank you for making these changes. I just have a question about the intended scope of this PR.

azuremanaged/build.gradle

samples/src/main/java/io/durabletask/samples/WebAppToDurableTaskSchedulerSample.java

…ment variable directly for consistency across modules

… environment variable directly for consistency across modules" This reverts commit bb1fbb1.

YunchuWang · 2025-03-21T15:27:07Z

pr connecting to production scheduler working

…d "client", gradle expects unique module names and build one module only if colliding names

settings.gradle

cgillum

Added a few comments.

Can you also update the CHANGELOG.md file?

.../src/main/java/com/microsoft/durabletask/azuremanaged/DurableTaskSchedulerClientOptions.java

...c/main/java/com/microsoft/durabletask/azuremanaged/DurableTaskSchedulerConnectionString.java

azuremanaged/build.gradle

kaibocai · 2025-03-24T17:18:40Z

Probably Waiting for @cgillum approvement as well.

...c/main/java/com/microsoft/durabletask/azuremanaged/DurableTaskSchedulerConnectionString.java

…tion types in DurableTaskSchedulerConnectionString. Update tests to verify new credential types.

…onnectionString. Update tests to verify the new credential type.

Add gradle task to update submodule and update proto to latest version

51d210f

YunchuWang requested review from cgillum, kaibocai and shreyas-gopalakrishna as code owners January 23, 2025 06:18

bump build pipeline github action version to non deprecated version

8660f1b

initial dts support changes

8a54ce4

YunchuWang marked this pull request as draft January 23, 2025 18:44

YunchuWang changed the title ~~Add gradle task to update submodule and update proto to latest version~~ Update protos to latest version, remove submodule, include completionToken required in latest complete grpc calls def Jan 23, 2025

YunchuWang added 7 commits January 23, 2025 11:05

placeholder

f951428

ignore

12e9e50

update

3b09d59

remove

32eca1e

update

ea2e181

update

e025538

update

6ea3a65

YunchuWang marked this pull request as ready for review January 23, 2025 20:24

signing is disabled, should not exclude as there is no sign

2270ed2

cgillum reviewed Jan 23, 2025

View reviewed changes

YunchuWang added 4 commits January 29, 2025 00:03

save

9a02b23

feedback changes

8fb193f

delete legacy lib/java

a51ba86

create skeleton project for pkg "com.microsoft.durabletask-azuremanaged"

7241e34

cgillum reviewed Jan 30, 2025

View reviewed changes

azuremanaged/build.gradle Outdated Show resolved Hide resolved

samples/src/main/java/io/durabletask/samples/WebAppToDurableTaskSchedulerSample.java Show resolved Hide resolved

YunchuWang added 5 commits March 14, 2025 12:27

split pkg in progress

8688320

move out

628c093

progress

a7e8d19

p

ab89785

progress

6fc0748

YunchuWang added 4 commits March 20, 2025 17:17

Update PATH_TO_TEST_JAVA_RUNTIME in build.gradle files to use environ…

bb1fbb1

…ment variable directly for consistency across modules

Revert "Update PATH_TO_TEST_JAVA_RUNTIME in build.gradle files to use…

637863c

… environment variable directly for consistency across modules" This reverts commit bb1fbb1.

separate build and unit tests

8d530cb

use jdk11 for unit tests

5f3ebfb

YunchuWang added 3 commits March 21, 2025 08:28

update sample

02ec66d

clean up

f23edcc

rename azuremanaged module names to avoid colliding module names name…

299ab73

…d "client", gradle expects unique module names and build one module only if colliding names

kaibocai previously approved these changes Mar 21, 2025

View reviewed changes

YunchuWang changed the title ~~DTS Support + CompletionToken fix for proto update~~ DTS Support Mar 21, 2025

cgillum reviewed Mar 21, 2025

View reviewed changes

settings.gradle Outdated Show resolved Hide resolved

update azure managed to one package

8cf6cdb

YunchuWang dismissed kaibocai’s stale review via 8cf6cdb March 21, 2025 22:40

YunchuWang requested a review from cgillum March 21, 2025 22:41

cgillum reviewed Mar 22, 2025

View reviewed changes

conn str support

1bebf5a

YunchuWang requested a review from cgillum March 23, 2025 19:40

changelog

98cf7eb

kaibocai previously approved these changes Mar 24, 2025

View reviewed changes

cgillum reviewed Mar 24, 2025

View reviewed changes

...c/main/java/com/microsoft/durabletask/azuremanaged/DurableTaskSchedulerConnectionString.java Show resolved Hide resolved

Add support for Visual Studio Code and Interactive Browser authentica…

8705055

…tion types in DurableTaskSchedulerConnectionString. Update tests to verify new credential types.

YunchuWang dismissed kaibocai’s stale review via 8705055 March 24, 2025 19:45

Add support for IntelliJ authentication type in DurableTaskSchedulerC…

ad72eca

…onnectionString. Update tests to verify the new credential type.

YunchuWang requested a review from cgillum March 24, 2025 20:27

cgillum approved these changes Mar 24, 2025

View reviewed changes

cgillum merged commit 661cae5 into main Mar 24, 2025
4 checks passed

cgillum deleted the wangbill/update-proto branch March 24, 2025 20:35

JoshVanL pushed a commit to JoshVanL/durabletask-java that referenced this pull request May 7, 2025

Durable Task Scheduler SDK Support (microsoft#201)

2fc1b24

JoshVanL pushed a commit to JoshVanL/durabletask-java that referenced this pull request May 28, 2025

Durable Task Scheduler SDK Support (microsoft#201)

0da7ef7

DTS Support #201

DTS Support #201

Uh oh!

Conversation

YunchuWang commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Configuration Updates:

Client Extensions:

Client Options:

Token Management:

Workflow Adjustment:

Issue describing the changes in this PR

Pull request checklist

Additional information

Uh oh!

cgillum commented Jan 23, 2025

Uh oh!

YunchuWang commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgillum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cgillum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

YunchuWang commented Mar 21, 2025

Uh oh!

Uh oh!

cgillum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kaibocai commented Mar 24, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YunchuWang commented Jan 23, 2025 •

edited

Loading

YunchuWang commented Jan 23, 2025 •

edited

Loading