Split e2e tests from samples #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaibocai
commented
Nov 28, 2023
| } | ||
|
|
||
| @Test | ||
| // @Test |
Member
Author
There was a problem hiding this comment.
This test is pretty flaky, commented it out for now, will investigate this one and create PR accordingly. It may be an issue with the sidecar.
kaibocai
requested review from
cgillum and
shreyas-gopalakrishna
as code owners
cgillum
reviewed
Nov 28, 2023
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
If I understand this change correctly, it looks like we're no longer running the samples in the CI but just the new E2E tests. Can we do both? Having automation that tests the samples, even minimally, is useful to help ensure we don't accidentally break the samples. Maybe we could have two separate GitHub workflows, one that tests the samples (like we had before) and one that does more general E2E testing?
Member
Author
|
Yes, I can add back the tests for samples. |
Member
Author
|
Add back tests for samples! @cgillum |
cgillum
reviewed
Nov 28, 2023
cgillum
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
This PR split e2e test suit from function samples, adding flexibility to create end-to-end tests.
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information