Fix infinite loop when use continueasnew after wait external event #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaibocai
requested review from
cgillum and
shreyas-gopalakrishna
as code owners
kaibocai
changed the title
kamperiadis
approved these changes
Nov 14, 2023
Contributor
kamperiadis
left a comment
kamperiadis
left a comment
There was a problem hiding this comment.
LGTM! Thank you @kaibocai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #182
This PR fix a bug with the
carrayOverEventsofcontinueAsNewAPI. The old implementation loops through the wholenewEventslist to addEVENTRAISEDtocarrayOverEvents, which is not correct. With this fix, it only loops through events that haven't been processed in thenewEventslist.Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information