Add deterministic GUID generation #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaibocai
requested review from
cgillum and
shreyas-gopalakrishna
as code owners
kaibocai
requested review from
cgillum and
davidmrdavid
and removed request for
cgillum and
shreyas-gopalakrishna
cgillum
approved these changes
Oct 24, 2023
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
LGTM! Just one question about a doc comment, but otherwise I think this implementation looks good.
client/src/main/java/com/microsoft/durabletask/TaskOrchestrationContext.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work needed to allow orchestrations to generate random GUIDs in a deterministic way. It borrows from the similar logic in the durabletask-dotnet SDK.
Also this is request from dapr/java-sdk#931
resolves #issue_for_this_pr
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information