Break long timers into smaller timers #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamperiadis
requested review from
cgillum,
kaibocai and
shreyas-gopalakrishna
as code owners
cgillum
reviewed
Mar 7, 2023
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
This looks great! Just a couple small suggestions from me.
client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java
Outdated
Show resolved
Hide resolved
client/src/test/java/com/microsoft/durabletask/IntegrationTests.java
Outdated
Show resolved
Hide resolved
kaibocai
reviewed
Mar 7, 2023
Member
kaibocai
left a comment
kaibocai
left a comment
There was a problem hiding this comment.
LGTM, add 2 minnor comments.
| } | ||
|
|
||
| /** | ||
| * Sets the maximum timer interval. If not specified, the default maximum timer interval duration will be used. |
Member
There was a problem hiding this comment.
we can mention the current default duration is 3 days.
Comment on lines
556
to
559
| while (remainingTime.compareTo(this.maximumTimerInterval) > 0) { | ||
| Instant nextFireAt = this.currentInstant.plus(this.maximumTimerInterval); | ||
| createInstantTimer(this.sequenceNumber++, nextFireAt).await(); | ||
| remainingTime = Duration.between(finalFireAt, this.currentInstant); |
Member
There was a problem hiding this comment.
Similar logics should also be added to method createTimer(ZoneDateTime)
kaibocai
approved these changes
Mar 7, 2023
cgillum
approved these changes
Mar 7, 2023
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
LGTM (Looks Good To Me)!
Just one minor suggestion which you can choose to incorporate or skip.
client/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java
Outdated
Show resolved
Hide resolved
|
@kamperiadis Is this released in the SDK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Resolves #114
Currently, we do not support timers longer than 7 days. However, the changes in this PR work around that by breaking up a single long timer into several shorter ones.
Pull request checklist
CHANGELOG.md