Open
Conversation
Author
|
@microsoft-github-policy-service agree |
placintaalexandru
force-pushed
the
fix/Build-on-recent-libc++
branch
from
0bcfaff to
396259a
Compare
This was referenced Apr 22, 2025
aminya
added a commit
to aminya/vcpkg
that referenced
this pull request
May 5, 2025
Cpprestsdk fails to compile on newer MacOS due to missing char_traits. This provides the fix from microsoft/cpprestsdk#1820 Related to microsoft/cpprestsdk#1812
aminya
added a commit
to aminya/vcpkg
that referenced
this pull request
May 5, 2025
Cpprestsdk fails to compile on newer MacOS due to missing char_traits. This provides the fix from microsoft/cpprestsdk#1820 Related to microsoft/cpprestsdk#1812
7 tasks
aminya
added a commit
to aminya/vcpkg
that referenced
this pull request
May 5, 2025
Cpprestsdk fails to compile on newer MacOS due to missing char_traits. This provides the fix from microsoft/cpprestsdk#1820 Related to microsoft/cpprestsdk#1812
aminya
added a commit
to aminya/vcpkg
that referenced
this pull request
May 5, 2025
Cpprestsdk fails to compile on newer MacOS due to missing char_traits. This provides the fix from microsoft/cpprestsdk#1820 Related to microsoft/cpprestsdk#1812
Member
|
This PR introduces undefined behavior: https://eel.is/c++draft/requirements#namespace.std-2 There is no program-defined type here. This also fails if 2 libraries try to do this. |
aminya
suggested changes
May 5, 2025
| @@ -0,0 +1,74 @@ | |||
| #include <cstdint> | |||
There was a problem hiding this comment.
Suggested change
| #include <cstdint> | |
| #pragma once | |
| #include <cstddef> | |
| #if (_LIBCPP_VERSION >= 190000) | |
| #include <cstdint> |
|
|
||
| static int_type eof() noexcept { return static_cast<int_type>(-1); } | ||
| }; | ||
| } // namespace std |
There was a problem hiding this comment.
Suggested change
| } // namespace std | |
| } // namespace std | |
| #endif // (_LIBCPP_VERSION >= 190000) |
aminya
added a commit
to aminya/vcpkg
that referenced
this pull request
Jun 6, 2025
Cpprestsdk fails to compile on newer MacOS due to missing char_traits. This provides the fix from microsoft/cpprestsdk#1820 Related to microsoft/cpprestsdk#1812
aminya
added a commit
to aminya/vcpkg
that referenced
this pull request
Jun 28, 2025
Cpprestsdk fails to compile on newer MacOS due to missing char_traits. This provides the fix from microsoft/cpprestsdk#1820 Related to microsoft/cpprestsdk#1812
aminya
added a commit
to aminya/vcpkg
that referenced
this pull request
Jul 5, 2025
Cpprestsdk fails to compile on newer MacOS due to missing char_traits. This provides the fix from microsoft/cpprestsdk#1820 Related to microsoft/cpprestsdk#1812
aminya
added a commit
to aminya/vcpkg
that referenced
this pull request
Jul 6, 2025
Cpprestsdk fails to compile on newer MacOS due to missing char_traits. This provides the fix from microsoft/cpprestsdk#1820 Related to microsoft/cpprestsdk#1812
|
I guess a proper fix would be
|
|
Using unsigned types with any of the string and stream templates is a can of worms. As far as I know the C++ standard does not mandate the standard library to support unsigned char types in those. I think ideally only the standard char types should be used, and applications using stream apis should convert from and to unsigned types if they need to in application code. But it would unfortunately be a breaking change. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 1812
char_traits<uint8_t>type was not supplied