Spelling by jsoref · Pull Request #1813 · microsoft/cpprestsdk

jsoref · 2024-12-12T08:08:25Z

This PR corrects misspellings identified by the check-spelling action (which is an evolution of the script I used ages ago when I first made a PR here...).

The misspellings have been reported at https://github.com/jsoref/cpprestsdk/actions/runs/12292228454#summary-34302451221

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/cpprestsdk/actions/runs/12292228864#summary-34302452484

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2024-12-12T08:09:32Z

Build_iOS/README.md

@@ -1 +1 @@
-Please consult the documentation [here](https://github.com/Microsoft/cpprestsdk/wiki/How-to-build-for-iOS) for iOS compilation.
+Please consult the [documentation for iOS compilation](https://github.com/Microsoft/cpprestsdk/wiki/How-to-build-for-iOS).


This is based on an accessibility complaint (for people using screen readers):

Do not use (click) here links

For more information, see:

https://www.w3.org/QA/Tips/noClickHere

https://webaim.org/techniques/hypertext/link_text

https://granicus.com/blog/why-click-here-links-are-bad/

https://heyoka.medium.com/dont-use-click-here-f32f445d1021

(?i)(?:>|\[)(?:(?:click |)here|link|(?:read |)more)(?:</|\]\()

jsoref · 2024-12-12T08:11:03Z

Release/include/cpprest/json.h

    malformed_string_literal,
    malformed_token,
-    mismatched_brances,
+    mismatched_braces,


this could be an API break

jsoref · 2024-12-12T08:12:04Z

Release/samples/BlackJack/BlackJack_UIClient/CardShape.xaml

                </TransformGroup>
            </Canvas.RenderTransform>
-            <Image HorizontalAlignment="Left" Source="Cards.PNG" Stretch="None" VerticalAlignment="Top" RenderTransformOrigin="0.05,0.08" x:Name="imgCard">
+            <Image HorizontalAlignment="Left" Source="cards.png" Stretch="None" VerticalAlignment="Top" RenderTransformOrigin="0.05,0.08" x:Name="imgCard">


the file is renamed below

jsoref · 2024-12-12T08:12:22Z

Release/samples/BlackJack/BlackJack_UIClient/cards.png

the corresponding reference is renamed above

jsoref · 2024-12-12T08:13:24Z

Release/src/utilities/asyncrt_utils.cpp


    // The format is:
-    // PdaysDThoursHminutesMsecondsS
+    // "P"+(days+"D")?+"T"+(hours+"H")?+(minutes+"M")?+(seconds+"S")?


this was a very manual change. I don't think the previous text was particularly readable...

jsoref · 2024-12-12T08:13:56Z

Release/tests/functional/http/client/proxy_tests.cpp

                 http_proxy_with_credentials,
                 "Ignore:Linux",
-                 "Github 53",
+                 "GitHub 53",


I'm not sure what this is doing, it's possible it can't be applied... happy to drop if it's a problem...

jsoref · 2024-12-12T08:14:56Z

ThirdPartyNotices.txt

 base64.cpp and base64.h

-Copyright (C) 2004-2008 Ren� Nyffenegger
+Copyright (C) 2004-2008 Ren� Nyffenegger


I'm not sure what happened to this line. I blame VS Code

jsoref · 2024-12-12T08:15:28Z

ThirdPartyNotices.txt


 ****** SHA1 Library (sha1/sha1.hpp) ******
-sha1.hpp is a repackaging of the sha1.cpp and sha1.h files from the shallsha1
+sha1.hpp is a repackaging of the sha1.cpp and sha1.h files from the smallsha1


I don't normally change files like this, but this typo seemed sufficiently problematic/worthy of correcting.

jsoref · 2024-12-12T08:15:54Z

changelog.md

 cpprestsdk (2.10.17)
 * PR#1550 Fix year calculation for the last day of a leap year
-* PR#1523 Fix wrong linking of Apple Frameworks on MacOS
+* PR#1523 Fix wrong linking of Apple Frameworks on macOS


Some projects don't like changing changelogs, I'm happy to drop this (or anything else) if it's a problem.

Zelmoron · 2025-12-11T07:14:09Z

nice

jsoref · 2025-12-11T12:05:00Z

@StephanTLavavej ?

StephanTLavavej · 2025-12-11T12:13:30Z

cpprestsdk is in deep maintenance mode. We strongly discourage its use, and are fixing only security vulnerabilities and eyeball-liquefying bugs. Spelling errors don't meet that bar, sorry.

(I am constantly advocating for outright archiving cpprestsdk.)

jsoref added 30 commits December 10, 2024 23:09

link: documentation for iOS compilation

b265671

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

make format easier to read

a8fb56f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: above

511cfa6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: ambiguity

7b7cc22

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: an

9e96d0f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: anymore

85ce393

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: architecture

4b62944

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: asynchronously

668acff

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: available

88b5584

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: because

bf48ef1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: beginning

b28e7e7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: braces

820d23a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: canceled

f2c1a07

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: cannot

4f68c0b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: cards.png

ba3d78b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: carriage

ac70b42

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: case-insensitive

619546b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: case-sensitive

a9bf698

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: command

82268e7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: consumer

443ccc5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: continue

f5d4454

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: conversion

de0a6f6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: delimiter

5eea00c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: description

8fd3dc4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: doesn't

b2e0e45

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: encoded

d53c601

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: file

b8d7178

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: github

c53a93e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: http

d834002

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: initial

74a5041

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 25 commits December 11, 2024 21:36

spelling: receive

303dfbb

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: remarks

773d869

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: restriction

b99fc00

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: revisit

08cbf55

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: separated

3ae793a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: separately

43cd800

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: serialization

f4fa636

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: server

fd7c567

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: setand

9c15a85

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: smallsha1

c2a7c18

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: specific

858cb05

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: specifying

7ba16b2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: statement

2474170

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: subtracting

cb6caf5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: succeeds

a083ccb

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: successfully

19bdfb1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: task

df379d1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: the

f1e7863

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: thread count

112a20d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: to which the gridview binds

d120a80

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transfer

68ab880

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transferred

4b11b9d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transparent

2081008

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: vector

8088906

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: will

6872296

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref commented Dec 12, 2024

View reviewed changes

jsoref mentioned this pull request Dec 12, 2024

Upgrade to check-spelling v0.0.24 microsoft/winget-cli#5045

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling#1813

Spelling#1813
jsoref wants to merge 70 commits intomicrosoft:masterfrom
jsoref:spelling

jsoref commented Dec 12, 2024

Uh oh!

jsoref Dec 12, 2024

Uh oh!

jsoref Dec 12, 2024

Uh oh!

jsoref Dec 12, 2024

Uh oh!

jsoref Dec 12, 2024

Uh oh!

jsoref Dec 12, 2024

Uh oh!

jsoref Dec 12, 2024

Uh oh!

jsoref Dec 12, 2024

Uh oh!

jsoref Dec 12, 2024

Uh oh!

jsoref Dec 12, 2024

Uh oh!

Zelmoron commented Dec 11, 2025

Uh oh!

jsoref commented Dec 11, 2025

Uh oh!

StephanTLavavej commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -1 +1 @@
		Please consult the documentation [here](https://github.com/Microsoft/cpprestsdk/wiki/How-to-build-for-iOS) for iOS compilation.
		Please consult the [documentation for iOS compilation](https://github.com/Microsoft/cpprestsdk/wiki/How-to-build-for-iOS).

Conversation

jsoref commented Dec 12, 2024

Uh oh!

Choose a reason for hiding this comment

Do not use (click) here links

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zelmoron commented Dec 11, 2025

Uh oh!

jsoref commented Dec 11, 2025

Uh oh!

StephanTLavavej commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Do not use `(click) here` links