Gate stdext::checked_array_iterator usage on _ITERATOR_DEBUG_LEVEL#1072
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Mar 20, 2019
bryan-lipinski:user/bryanli/1069-fix-win-libc++-build
Merged
Gate stdext::checked_array_iterator usage on _ITERATOR_DEBUG_LEVEL#1072BillyONeal merged 2 commits intomicrosoft:masterfrom bryan-lipinski:user/bryanli/1069-fix-win-libc++-build
BillyONeal merged 2 commits intomicrosoft:masterfrom
bryan-lipinski:user/bryanli/1069-fix-win-libc++-build
Conversation
BillyONeal
reviewed
Mar 19, 2019
Member
|
The one Pipelines failure was a spurious network issue. Looks good to me, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1069
checked_array_iterator is a Microsoft extension to the C++ Standard Library. In order to build cpprestsdk using other libraries such as libc++, the extension needs to be gated with a Microsoft specific macro. In this case _ITERATOR_DEBUG_LEVEL is the preferred macro for using checked iterators (As _SECURE_SCL is marked deprecated) .
I've validated this builds using MSVC and clang.cl.exe/libc++.
Note: The CMake file sets _SCL_SECURE_NO_WARNINGS which disables the warning that the code in question is attempting to fix.
elseif(WIN32)add_definitions(-DUNICODE -D_UNICODE -DWIN32 -D_SCL_SECURE_NO_WARNINGS)