Don't close the output stream when reporting errors reading the body.#1068
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Mar 19, 2019
Merged
Don't close the output stream when reporting errors reading the body.#1068BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
…ed the stream on the user's behalf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the asio implementation to what the winhttp implementation was doing.
Also turned on a test that looked related; I'm not positive that this change fixed that test but it passes for me now.