Add the missing ssl::context callback in websocket_client_config#1049
Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom Mar 20, 2019
Merged
Conversation
…rowing heavily from http_client
…re WebSocket, just like for http_client when CPPREST_HTTP_CLIENT_IMPL STREQUAL "asio"
Contributor
Author
|
@BillyONeal I don't think the reported CI failures are actually related to this PR, am I right? |
Member
|
I think I managed to kick off another try: https://dev.azure.com/vclibs/cpprestsdk/_build/results?buildId=306 Will keep you posted. |
Contributor
Author
|
Thanks. It looks like the same two platforms failed:
|
Member
|
Something is borked with Pipelines and vcpkg right now; I reported to vcpkg folks and will keep you posted. |
Contributor
Author
…ssl_context_callback
Member
|
Looks like Pipelines is off the floor and your change works. Do want to add a test case for this? (This is small enough that I'll merge it without a test added but we're liable to break the feature on you again without it) |
Member
|
I guess we can always add that test later. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be able to set up certificates. Exactly the same use case as http_client_config and borrowing heavily from http_client implementation.