This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Cleanup OAuth, use clean interceptor pattern#51
Merged
Merged
Conversation
johnataylor
approved these changes
Jul 6, 2018
| HashMap <String, String> qstrings = new HashMap<>(); | ||
| qstrings.put("userId", userId); | ||
| qstrings.put("connectionName", connectionName); | ||
| if (!StringUtils.isBlank(magicCode)) |
| return null; | ||
| } | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
Member
There was a problem hiding this comment.
is eating the exception intended?
Contributor
Author
There was a problem hiding this comment.
Yes, failure condition to caller
| if (statusCode == HTTP_OK) | ||
| return response.body().string(); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
Contributor
Author
There was a problem hiding this comment.
Yeah, hard to get context - these are retrieving strings and tokens and stuff. If it fails, just returns null or false in one case.
| if (statusCode == HTTP_OK) | ||
| return; | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up alot of stuff, abandon C# style token resolve, and make fully async.