Build MicrosoftMLRunner for using WinML nuget and make WinMLRunner only load from System32#348
Merged
Build MicrosoftMLRunner for using WinML nuget and make WinMLRunner only load from System32#348
Conversation
added 11 commits
August 27, 2020 17:19
added 2 commits
September 4, 2020 10:38
remove pragma in outputhelper.cpp
ryanlai2
commented
Sep 4, 2020
| @@ -0,0 +1,1004 @@ | |||
| #include "d3dx12.h" | |||
Contributor
Author
There was a problem hiding this comment.
Implementation was moved from BindingUtilties.h into BindingUtilities.cpp
ryanlai2
commented
Sep 4, 2020
| @@ -0,0 +1,1197 @@ | |||
| #include "Common.h" | |||
Contributor
Author
There was a problem hiding this comment.
Implementation was moved from OutputHelper.h into OutputHelper.cpp
tiagoshibata
reviewed
Sep 4, 2020
tiagoshibata
reviewed
Sep 4, 2020
added 3 commits
September 8, 2020 14:15
tiagoshibata
reviewed
Sep 9, 2020
Tools/WinMLRunner/src/OutputHelper.h
Outdated
| } | ||
|
|
||
| const std::string& status) const; | ||
| void PrintModelInfo(std::wstring modelPath, LearningModel model) const; |
Contributor
There was a problem hiding this comment.
Should take const references
tiagoshibata
reviewed
Sep 9, 2020
Tools/WinMLRunner/src/OutputHelper.h
Outdated
| static void PrintLearningModelDevice(const LearningModelDeviceWithMetadata& device); | ||
| static std::wstring FeatureDescriptorToString(const ILearningModelFeatureDescriptor& descriptor); | ||
| static bool doesDescriptorContainFP16(const ILearningModelFeatureDescriptor& descriptor); | ||
| static bool doesModelContainFP16(const LearningModel model); |
Contributor
There was a problem hiding this comment.
Should take const reference
tiagoshibata
approved these changes
Sep 9, 2020
Contributor
tiagoshibata
left a comment
tiagoshibata
left a comment
There was a problem hiding this comment.
Looks good to me, left a couple of comments on the refactored code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few changes here: