Move Docker call outside network lock - #41362
Open
beena352 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces lock contention in the Windows-side WSLC session network listing path by avoiding holding m_networksLock across the Docker network-list HTTP round trip in WSLCSession::ListNetworks.
Changes:
- Moves acquisition of
m_networksLockto after the (filtered)m_runtime.Docker().ListNetworks(filters)call. - Keeps locking scoped to only protecting access to the
m_networkscache during sizing and iteration.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
beena352
marked this pull request as ready for review
August 14, 2026 22:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
WSLCSession::ListNetworks was holding m_networksLock while making the Docker /networks HTTP call. Since ListNetworks only reads from m_networks, the lock is only needed when accessing the cache, not during the Docker call.
This matches the existing pattern in WSLCVolumes::ListVolumes, which makes the Docker call first and then acquires the cache lock. There is no known user-visible issue; this change just avoids holding the lock during I/O.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed