Relate importsNotUsedAsValues -> preserveValueImports#2249
Merged
jakebailey merged 1 commit intomicrosoft:v2from May 18, 2023
Merged
Relate importsNotUsedAsValues -> preserveValueImports#2249jakebailey merged 1 commit intomicrosoft:v2from
jakebailey merged 1 commit intomicrosoft:v2from
Conversation
Contributor
Author
|
I think the CI failure is fixed by microsoft/TypeScript-Website-Localizations#135? |
Merged
Contributor
|
Agree, looks good to me |
jakebailey
approved these changes
May 18, 2023
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
LGTM though we should really also add verbatimModuleSyntax. Clearly, this PR is old so I'm not surprised it's not here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preserveValueImportsis already related toimportsNotUsedAsValuesin the tsconfig reference. Add the reciprocal link, like #1099.