Merged
Conversation
Contributor
Got false positives?Make changes to the global settings spellcheck.json in /artsy/peril-settings. Typos for noImplicitAny.md
Typos for files.md
Typos for Basic_Options_6172.md
Typos for README.md
Typos for useDefineForClassFields.md
Typos for typeRoots.md
Typos for typeAcquisition.md
Typos for target.md
Typos for suppressImplicitAnyIndexErrors.md
Typos for stripInternal.md
Typos for strictFunctionTypes.md
Typos for strict.md
Typos for sourceMap.md
Typos for resolveJsonModule.md
Typos for removeComments.md
Typos for pretty.md
Typos for preserveSymlinks.md
Typos for preserveConstEnums.md
Typos for plugins.md
Typos for outFile.md
Typos for outDir.md
Typos for out.md
Typos for noImplicitUseStrict.md
Typos for noFallthroughCasesInSwitch.md
Typos for noEmitHelpers.md
Typos for noEmit.md
Typos for newLine.md
Typos for moduleResolution.md
Typos for mapRoot.md
Typos for lib.md
Typos for keyofStringsOnly.md
Typos for isolatedModules.md
Typos for inlineSourceMap.md
Typos for incremental.md
Typos for importHelpers.md
Typos for generateCpuProfile.md
Typos for files.md
Typos for extends.md
Typos for esModuleInterop.md
Typos for downlevelIteration.md
Typos for disableSourceOfProjectReferenceRedirect.md
Typos for declarationDir.md
Typos for declaration.md
Typos for charset.md
Typos for alwaysStrict.md
Typos for allowUmdGlobalAccess.md
Typos for allowSyntheticDefaultImports.md
Typos for README.md
Typos for README.md
Typos for README.md
Lighthouse Scores
|
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.78 | 1 | 0.93 | 0.88 | 0.74 |
/en/tsconfig
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.92 | 0.95 | 1 | 0.86 | 0.7 |
color-contrast
Background and foreground colors do not have a sufficient contrast ratio. Low-contrast text is difficult or impossible for many users to read. Learn more.
| Failing Elements |
|---|
// @filename: index.ts: <span style="color: #4C566A">// @filename: index.ts</span> |
// @filename: card.js: <span style="color: #4C566A">// @filename: card.js</span> |
// @filename: index.ts: <span style="color: #4C566A">// @filename: index.ts</span> |
// @filename: index.ts: <span style="color: #4C566A">// @filename: index.ts</span> |
// parseFloat only takes a string: <span style="color: #4C566A">// parseFloat only takes a string</span> |
// @filename: constants.js: <span style="color: #4C566A">// @filename: constants.js</span> |
/// : <span style="color: #4C566A">/// </span> |
// @filename: index.ts: <span style="color: #4C566A">// @filename: index.ts</span> |
// @filename: constants.js: <span style="color: #4C566A">// @filename: constants.js</span> |
/// : <span style="color: #4C566A">/// </span> |
// @filename: index.ts: <span style="color: #4C566A">// @filename: index.ts</span> |
// helloWorld.ts: <span style="color: #4C566A">// helloWorld.ts</span> |
// helloWorld.js: <span style="color: #4C566A">// helloWorld.js</span> |
// helloWorld.js.map: <span style="color: #4C566A">// helloWorld.js.map</span> |
// The same, right?: <span style="color: #4C566A">// The same, right?</span> |
// true: <span style="color: #4C566A">// true</span> |
// false: <span style="color: #4C566A">// false</span> |
// No error?: <span style="color: #4C566A">// No error?</span> |
// When strictNullChecks: true: <span style="color: #4C566A">// When strictNullChecks: true</span> |
// Unsafe assignment: <span style="color: #4C566A">// Unsafe assignment</span> |
// Unsafe call - will crash: <span style="color: #4C566A">// Unsafe call - will crash</span> |
// With strictBindCallApply on: <span style="color: #4C566A">// With strictBindCallApply on</span> |
// @strictBindCallApply: false: <span style="color: #4C566A">// @strictBindCallApply: false</span> |
// With strictBindCallApply off: <span style="color: #4C566A">// With strictBindCallApply off</span> |
// Note that this.email is not set: <span style="color: #4C566A">// Note that this.email is not set</span> |
// @filename: utilFunctions.js: <span style="color: #4C566A">// @filename: utilFunctions.js</span> |
// @filename: index.ts: <span style="color: #4C566A">// @filename: index.ts</span> |
// @filename: utilFunctions.js: <span style="color: #4C566A">// @filename: utilFunctions.js</span> |
// do nothing: <span style="color: #4C566A">// do nothing</span> |
// do nothing: <span style="color: #4C566A">// do nothing</span> |
// do nothing: <span style="color: #4C566A">// do nothing</span> |
// @filename: settings.json: <span style="color: #4C566A">// @filename: settings.json</span> |
// @filename: index.ts: <span style="color: #4C566A">// @filename: index.ts</span> |
// @filename: settings.json: <span style="color: #4C566A">// @filename: settings.json</span> |
// @filename: index.ts: <span style="color: #4C566A">// @filename: index.ts</span> |
/**: <span style="color: #4C566A">/**</span> |
* Days available in a week: <span style="color: #4C566A"> * Days available in a week</span> |
* @internal: <span style="color: #4C566A"> * @internal</span> |
*/: <span style="color: #4C566A"> */</span> |
/**: <span style="color: #4C566A">/**</span> |
* Days available in a week: <span style="color: #4C566A"> * Days available in a week</span> |
* @internal: <span style="color: #4C566A"> * @internal</span> |
*/: <span style="color: #4C566A"> */</span> |
// Get API: <span style="color: #4C566A">// Get API</span> |
// Get API: <span style="color: #4C566A">// Get API</span> |
/*return*/: <span style="color: #4C566A">/*return*/</span> |
// Get API: <span style="color: #4C566A">// Get API</span> |
/*return*/: <span style="color: #4C566A">/*return*/</span> |
// Forgot 'return' statement: <span style="color: #4C566A">// Forgot 'return' statement</span> |
// @ts-ignore: <span style="color: #4C566A">// @ts-ignore</span> |
// Ok: <span style="color: #4C566A">// Ok</span> |
// Error: <span style="color: #4C566A">// Error</span> |
/docs/handbook/integrating-with-build-tools.html
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.95 | 0.93 | 1 | 0.89 | 0.74 |
Snapshots updated
backstop_default_Empty_Page_0_document_1_tablet.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_Empty_Page_0_document_2_computer.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_Index_0_document_0_phone.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_Index_0_document_1_tablet.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_Index_0_document_2_computer.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_Old_Handbook_Example_0_viewport_0_phone.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_Old_Handbook_Example_0_viewport_1_tablet.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_Old_Handbook_Example_0_viewport_2_computer.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_TSConfig_Example_0_viewport_0_phone.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_TSConfig_Example_0_viewport_1_tablet.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_TSConfig_Example_0_viewport_2_computer.png
| Before | After |
|---|---|
![]() |
![]() |
…or restoring code via URL
Closed
12 tasks
Contributor
Author
|
It's not perfect, but structurally its all there now, will come back and add some of the final polish later |
Contributor
Author
|
It's the a11y failing still, will merge for now |
This was referenced Sep 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






















The start of the two libraries:
Sandbox - a wrapper around monaco optimized for working with TS, with the goal as being useful for anyone to embed on their own sites
Playground - the same thing as https://www.typescriptlang.org/play/ (eventually, as typeScript and not one massive file)