[ja translation] TypeScript-Website/packages/documentation/copy/en/javascript/*.md#1478
Merged
orta merged 5 commits intomicrosoft:v2from Jan 21, 2021
Merged
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by @sasurau4, @Quramy, @Naturalclar, and @Takepepe - if they write a comment saying "LGTM" then it will be merged. |
…into feature/translation-docs-javascript
sasurau4
reviewed
Jan 13, 2021
Contributor
sasurau4
left a comment
sasurau4
left a comment
There was a problem hiding this comment.
packages/documentation/copy/ja/javascript/Creating DTS files From JS.mdだけ見ました
他のは後日見ます 🙏
packages/documentation/copy/ja/javascript/Creating DTS files From JS.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/ja/javascript/Creating DTS files From JS.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/ja/javascript/Creating DTS files From JS.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/ja/javascript/Creating DTS files From JS.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/ja/javascript/Creating DTS files From JS.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/ja/javascript/Creating DTS files From JS.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/ja/javascript/Creating DTS files From JS.md
Outdated
Show resolved
Hide resolved
sasurau4
reviewed
Jan 18, 2021
Contributor
sasurau4
left a comment
sasurau4
left a comment
There was a problem hiding this comment.
Review遅くなりました 🙏
ありがとうございます 👍
packages/documentation/copy/ja/javascript/Intro to JS with TS.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/ja/javascript/Intro to JS with TS.md
Outdated
Show resolved
Hide resolved
| // パラメータは様々な構文形式で宣言することができます | ||
| /** | ||
| * @param {string} p1 - 文字列パラメータ | ||
| * @param {string=} p2 - オプションのパラメータ(Closure構文) |
Contributor
There was a problem hiding this comment.
IMO: オプションでもいいんですが、設定と勘違いしそうなので、オプショナルの方が明確かと思いました
以下、オプションになってるところすべて同様です
採用するかはおまかせします。
Suggested change
| * @param {string=} p2 - オプションのパラメータ(Closure構文) | |
| * @param {string=} p2 - オプショナルなパラメータ(Closure構文) |
Contributor
Author
There was a problem hiding this comment.
https://github.com/microsoft/TypeScript-Website/pull/1478/files#r556283287 にて、"任意"とコメントいただいたので、オプションをすべて"任意"に変更しようと思います
packages/documentation/copy/ja/javascript/Type Checking JavaScript Files.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/ja/javascript/Type Checking JavaScript Files.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/ja/javascript/Type Checking JavaScript Files.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Daiki Ihara <sasurau4@gmail.com>
uraway
commented
Jan 18, 2021
|
|
||
| TypeScriptは、.d.tsファイルを見つけるためのステップを追加し、`package.json`の中でNodeのモジュール解決を再現します。 | ||
| 大まかには、モジュール解決はオプションである`"types"`フィールドをチェックし、次に`"main"`フィールド、そして最後にルートの`index.d.ts`を試します。 | ||
| 大まかには、モジュール解決は任意のフィールドである`"types"`フィールドをチェックし、次に`"main"`フィールド、そして最後にルートの`index.d.ts`を試します。 |
Contributor
Author
There was a problem hiding this comment.
そのまま「オプション」を「任意」に置き換えると変だったので、少し冗長かもですが、「任意のフィールド」としました
Contributor
Author
|
@sasurau4 いつもレビューありがとうございます 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #220
original files:
diff: f57223d