fix: incremental is default true only if composite is#1110
Merged
orta merged 1 commit intomicrosoft:v2from Sep 18, 2020
Merged
Conversation
- Compiler Options docs specify this behavior as such
- which I assume means if composite is false, incremental is also
false unless set explicitly, but I have never used it myself
Contributor
|
I read the compiler to try and figure this out, it generally looks like this is true and I think the 3.4 release notes also back up this change - thanks |
Contributor
Author
|
Thanks for double-checking; yea my read on the 3.4 release notes is similar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
false unless set explicitly, but I have never used it myself
Tags
Similar to #1102 and #1101 , found while investigating discrepancies between the TSConfig Reference and Compiler Options after finding #1092
Review Notes
I've not actually used this option per the description, so I haven't tested to see which is accurate. Perhaps the TSConfig Reference was correct and the Compiler Options docs were wrong and so this alignment change should be inverted