Treat ( followed by new line as parameter context for arrow, falling back to expression#552
Conversation
|
Fixed and release VS Code Extension version 0.0.34 that contains the fix. Please give it a try. |
|
Thank you for trying it out. I have fixed the reported issues and released VS Code Extension version 0.0.35 that contains the fix. Please give it a try. |
|
@sheetalkamat works great via the limited use I gave it, what will it take to get this into VS Code upstream? |
|
@jamesjryan we need more feedback and need to watch out for the bugs to see if this is really viable fix. Even though I t fixes these scenarios, it would break multiple other scenarios and bugs reported, tweaks possible and cases breaking would be factor in merging this PR. Eg. today #579 was reported and I looked through our code and there are multiple instances where this just fails.. |
d720e09 to
bf14f62
Compare
|
@sheetalkamat reporting a possible regression here - commenting a line using |
|
@jamesjryan can you please create a issue with sample code where this is failing, I am guessing this has nothing to do with this change, but i can look into it once i have a repro code. Thanks. |
|
FYI @mhegazy this is the PR that handles arrow function parameters that span on multiple lines |
Given that there are so many Issues that are getting duped to #481 and alike, i have created a branch that handles ( followed by line end as possibly arrow , this i am sure would lead to color few non arrow things as arrow (https://github.com/Microsoft/TypeScript-TmLanguage/pull/552/files#diff-a18148e1c0a6687d3019f4b439355bfbL290 will me marked as function instead of variable) but i am wondering if current behavior is better or the change here.
Handles #481, #498, #507, #524, #539, #550, #558, #564, #574