Rewrite and fixes for lot of grammar issues#257
Conversation
Note jsx attribute value is colored as string with this and its a TODO
…d object type's field declaration's type annotation
|
Nice work! Looking forward to testing it out. |
|
Should it also effect on this? And when will it be available? |
we should have this in a vscode extension for users to try it out next week. if every thing looks good, should be available in vscode's subsequent releases. |
|
Thanks a lot for the hard work! Can you give an overview of the most important grammar issues that get fixed in this PR? |
|
there are some 120 issues that are fixed by this change (linked above). it is almost a rewrite at this point. give it a try and let us know if there are other issues we are not aware of. |
So it is not available yet right? What will be need to it out, just use vscode insiders? |
|
@whitecolor the issue you mentioned seems to be fixed. |
|
@sheetalkamat is this going to be merged soon? Can i test it already? |
|
@farfromrefug you can find these changes in the VSCode extension: https://marketplace.visualstudio.com/items?itemName=ms-vscode.typescript-javascript-grammar |
|
Thanks @mhegazy will test it right away! |
No description provided.