Allowed digits at the end of method return type#240
Allowed digits at the end of method return type#240RichieAHB wants to merge 1 commit intomicrosoft:masterfrom
Conversation
|
Hi @RichieAHB, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@RichieAHB, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Hi @RichieAHB , this PR is similar to PR #199 . I see you have a good test here. You can either leave some comments on PR #199, or wait for that PR to be merged in and send out a PR to improve those changes. |
|
Sorry for the delay. the original issue should be fixed now by #257 |
4 participants
Fixes #153 - includes tests. The regex for
type-annotationwas looking for[a-zA-Z_$](the regex used for the first character) as the pattern for the last character rather than[\w$]. There are a few regexes around that allows[.\w$]for the last character of a type name but as far as I can tell, type names can't end with a dot so I've not included this.I have a plugin that removes whitespace at the end of lines so there are some rogue changes in here that I missed, which can be removed if required.