Conversation
|
Hi @chadhietala, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Hey @chadhietala, as a heads up, mentioning the issue you're fixing in the PR body actually links to it, and the PR title itself should typically be more descriptive so readers don't have to navigate to the original issue for full context. @anubmat can you take a look at this? |
|
@chadhietala, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Not sure how important the CLA is now that I will be working at a MS subsidiary... 😄 |
.vscode/settings.json
Outdated
| "editor.insertSpaces": true | ||
| } No newline at end of file | ||
| "editor.insertSpaces": true, | ||
| "files.trimTrailingWhitespace": false |
There was a problem hiding this comment.
I can remove this. I think I'm using this extension that adds a new line and tests care about whitespace.
|
@chadhietala, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
chadhietala
force-pushed
the
strings-methods
branch
2 times, most recently
from
f5dbf79 to
c4930a9
Compare
Attempt to fix microsoft#154
chadhietala
force-pushed
the
strings-methods
branch
from
c4930a9 to
71f3172
Compare
| method-declaration: | ||
| name: meta.method.declaration.ts | ||
| begin: '\b(?:(abstract)\s+)?\b(?:(public|private|protected)\s+)?\b(?:(async)\s+)?(?:(get|set)\s+)?(?:(new)|(?:\b(constructor)\b)|(?:([a-zA-Z_$][\.\w$]*)\s*(\??)))?\s*(?=\(|\<)' | ||
| begin: '\b(?:(abstract)\s+)?\b(?:(public|private|protected)\s+)?\b(?:(async)\s+)?(?:(get|set)\s+)?(?:(new)|(?:\b(constructor)\b)|(?:(\[*)(`|'|"*)(.*)(`|'|"*)(\]*)\s*(\??)))?\s*(?=\(|\<)' |
There was a problem hiding this comment.
This still doesn't look correct. For example, the .* would eat everything including the closing quote and bracket (the test case needs to be updated for it). Also, do you need to consider if the two quotes are matching? For example, ["test'] and ['test"] shouldn't be treated the same way as the ["test"]
|
The original issue should be fixed now by #257 |
5 participants
I actually have no idea if this is correct or not but thought I would put it up to get some feedback.
_Edit by @DanielRosenwasser:_ Fixes #154.