Improve WebAssembly import/export types - #755
Merged
Orta Therox (orta) merged 1 commit intoSep 23, 2019
Merged
Conversation
Sets more specific types to allowed imports/exports for WebAssembly.
Contributor
Author
|
Kagami Sascha Rosylight (@saschanaz) Ping, can you please take a look? Among improvements, this fixes a small bug I introduced in #752. |
Kagami Sascha Rosylight (saschanaz)
approved these changes
Sep 22, 2019
Kagami Sascha Rosylight (saschanaz)
left a comment
Kagami Sascha Rosylight (saschanaz)
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a nit.
Contributor
Author
|
Kagami Sascha Rosylight (@saschanaz) Can this be merged then? |
Contributor
|
I unfortunately don't have a write access. Pinging Orta Therox (@orta) |
Contributor
|
Cool, the output looks 👍 to me. Thanks Ingvar Stepanyan (@RReverser) - Kagami Sascha Rosylight (@saschanaz) ping me anytime you want |
Contributor
Author
|
Orta Therox (@orta) Thanks! Do you know if I need to do anything further to get definitions updated on the TypeScript side or are they pulled from here automatically on new release? |
Ingvar Stepanyan (RReverser)
deleted the
improve-wasm-imports-exports
branch
September 23, 2019 16:16
Contributor
Author
|
Argh, I just noticed that I missed |
Ingvar Stepanyan (RReverser)
added a commit
to RReverser/TSJS-lib-generator
that referenced
this pull request
Sep 23, 2019
Follow-up to microsoft#755.
Contributor
Author
|
Sent a follow-up PR. |
Ingvar Stepanyan (RReverser)
added a commit
to RReverser/TSJS-lib-generator
that referenced
this pull request
Sep 30, 2019
Based on microsoft#755 and microsoft#766, improves imports param in constructor instead.
This was referenced Sep 30, 2019
Nathan Shively-Sanders (sandersn)
pushed a commit
to microsoft/TypeScript
that referenced
this pull request
Oct 14, 2019
This bumps generated bindings to include microsoft/TypeScript-DOM-lib-generator#767. Note that other related APIs were already updated in microsoft/TypeScript-DOM-lib-generator#755 and microsoft/TypeScript-DOM-lib-generator#756 and included in current TypeScript beta. Unfortunately, this one slipped under the radar, but it would be really great to include these changes in beta too for consistency between different WebAssembly methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets more specific types to allowed imports/exports for WebAssembly.