Skip to content

Remove 'prerender' from document VisibilityState - #732

Merged
Nathan Shively-Sanders (sandersn) merged 1 commit into
microsoft:masterfrom
kripod:patch-1
Sep 23, 2019
Merged

Remove 'prerender' from document VisibilityState#732
Nathan Shively-Sanders (sandersn) merged 1 commit into
microsoft:masterfrom
kripod:patch-1

Conversation

@kripod

@kripod Kristóf Poduszló (kripod) commented Jun 18, 2019

Copy link
Copy Markdown
Contributor

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Jul 10, 2019

Copy link
Copy Markdown
Contributor

npm run build && npm run baseline-accept should be done to fix the test.

@kripod

Kristóf Poduszló (kripod) commented Jul 16, 2019

Copy link
Copy Markdown
Contributor Author

Kagami Sascha Rosylight (@saschanaz) Unfortunately, I get the following issues when running those commands:

> npm run build && npm run baseline-accept

> tsjs-lib-generator@ build D:\Development\Projects\TSJS-lib-generator
> tsc --p ./tsconfig.json && node ./lib/index.js

node_modules/@types/node/index.d.ts:74:11 - error TS2300: Duplicate identifier 'IteratorResult'.

74 interface IteratorResult<T> { }
             ~~~~~~~~~~~~~~

  node_modules/typescript/lib/lib.es2015.iterable.d.ts:41:6
    41 type IteratorResult<T, TReturn = any> = IteratorYieldResult<T> | IteratorReturnResult<TReturn>;
            ~~~~~~~~~~~~~~
    'IteratorResult' was also declared here.

node_modules/typescript/lib/lib.es2015.iterable.d.ts:41:6 - error TS2300: Duplicate identifier 'IteratorResult'.

41 type IteratorResult<T, TReturn = any> = IteratorYieldResult<T> | IteratorReturnResult<TReturn>;
        ~~~~~~~~~~~~~~

  node_modules/@types/node/index.d.ts:74:11
    74 interface IteratorResult<T> { }
                 ~~~~~~~~~~~~~~
    'IteratorResult' was also declared here.

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Jul 16, 2019

Copy link
Copy Markdown
Contributor

Try rebasing + npm i and do it again, as it's fixed in #737.

@kripod

Kristóf Poduszló (kripod) commented Jul 16, 2019

Copy link
Copy Markdown
Contributor Author

Kagami Sascha Rosylight (@saschanaz) Thanks for the tip, everything seems to work now.

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Jul 16, 2019

Copy link
Copy Markdown
Contributor

Tests pass, great! But I'm afraid that something is broken when merging and now this PR has some duplicated commits from the master branch. Would you try git merge again?

@kripod

Kristóf Poduszló (kripod) commented Jul 27, 2019

Copy link
Copy Markdown
Contributor Author

Kagami Sascha Rosylight (@saschanaz) I just recreated the entire PR with a force push to avoid issues.

@kripod

Kristóf Poduszló (kripod) commented Aug 20, 2019

Copy link
Copy Markdown
Contributor Author

Kagami Sascha Rosylight (@saschanaz) Sorry for interrupting, but may I ask if there is anything I may help with to get this PR merged?

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

Pinging Nathan Shively-Sanders (@sandersn)

@kripod

Kristóf Poduszló (kripod) commented Sep 19, 2019

Copy link
Copy Markdown
Contributor Author

Kagami Sascha Rosylight (@saschanaz) Nathan Shively-Sanders (@sandersn) I'm sorry to disturb again, but may I ask if there are any blocking factors to resolve regarding this PR?

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Sep 19, 2019 via email •
edited
Loading

Copy link
Copy Markdown
Contributor

@sandersn

Nathan Shively-Sanders (sandersn) commented Sep 23, 2019

Copy link
Copy Markdown
Member

Thanks for your patience! It's been a busy release.

@sandersn
Nathan Shively-Sanders (sandersn) merged commit bfae33e into microsoft:master Sep 23, 2019
@kripod Kristóf Poduszló (kripod) mentioned this pull request Sep 23, 2019
Closed
Merged
@qinyuhang

秦宇航 (qinyuhang) commented Oct 29, 2019

Copy link
Copy Markdown

I'm sorry but I failed to see why U remove prerender, It's still on in MDN https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState

@kripod

Kristóf Poduszló (kripod) commented Oct 29, 2019

Copy link
Copy Markdown
Contributor Author

秦宇航 (@qinyuhang) It’s marked as deprecated and has already been removed from the corresponding spec.

@HolgerJeromin

Holger Jeromin (HolgerJeromin) commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

I marked it as deprecated in MDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove 'prerender' value from VisibilityState

5 participants

@kripod @saschanaz @sandersn @qinyuhang @HolgerJeromin