Skip to content

Add property of AudioContext state API#30

Merged
zhengbli merged 1 commit into
microsoft:masterfrom
rixrix:AudioContext_state
Dec 11, 2015
Merged

Add property of AudioContext state API#30
zhengbli merged 1 commit into
microsoft:masterfrom
rixrix:AudioContext_state

Conversation

@rixrix

@rixrix rixrix commented Dec 9, 2015

Copy link
Copy Markdown

Hi

This fixes microsoft/TypeScript#5816

This is my first PR, would be good if someone can give feedback. thanks

@msftclas

msftclas commented Dec 9, 2015

Copy link
Copy Markdown

Hi @rixrix, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas

msftclas commented Dec 9, 2015

Copy link
Copy Markdown

@rixrix, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@mhegazy

mhegazy commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

the webidl files are not supposed to change. please see https://github.com/Microsoft/TSJS-lib-generator#contribution-guide for how you can augment definitions.

@rixrix

rixrix commented Dec 9, 2015

Copy link
Copy Markdown
Author

@mhegazy great, I'll look into it. thanks

@rixrix rixrix force-pushed the AudioContext_state branch from c1c07d6 to e9be0cb Compare December 9, 2015 20:25
@rixrix

rixrix commented Dec 9, 2015

Copy link
Copy Markdown
Author

@mhegazy if you could look at it again, that'd be great. Previous change set was definitely a mistake. cheers

@mhegazy

mhegazy commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

👍

@zhengbli

Copy link
Copy Markdown

👍 Thanks for the contribution @rixrix !

zhengbli pushed a commit that referenced this pull request Dec 11, 2015
Add property of AudioContext state API
@zhengbli zhengbli merged commit 472b4b1 into microsoft:master Dec 11, 2015
@rixrix rixrix deleted the AudioContext_state branch December 11, 2015 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AudioContextState missing in lib.d.ts

4 participants