Add overrides to Node & NamedNodeMap interfaces#296
Closed
dsifford wants to merge 1 commit intomicrosoft:masterfrom
dsifford:dsifford-node-namednodemap
Closed
Add overrides to Node & NamedNodeMap interfaces#296dsifford wants to merge 1 commit intomicrosoft:masterfrom dsifford:dsifford-node-namednodemap
dsifford wants to merge 1 commit intomicrosoft:masterfrom
dsifford:dsifford-node-namednodemap
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles two open issues in the TypeScript repo.
resolves microsoft/TypeScript#17695
and
resolves microsoft/TypeScript#18194
This is my first time contributing here so if there's something I missed, or something that I can improve next time, please don't hesitate to let me know! Thanks so much! 😄