Repository navigation
Type WebAssembly.Memory buffers as ArrayBufferLike for shared memories - #2592
Open
Martin Ferret (MartinFerret) wants to merge 1 commit into
Open
Martin Ferret (MartinFerret) wants to merge 1 commit into
Martin Ferret (MartinFerret) wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
Member
|
This is definitely something I think we're going to have to run extended tests on before doing |
Contributor
Author
|
I totally agree. The main risk in my opinion is code using a plain |
Contributor
|
Jake Bailey (@jakebailey) are you willing to do the test? 👀 |
Member
|
Running on microsoft/TypeScript#65437 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2447
As we talked about in the issue, when you create a memory with
shared: true, it gives you aSharedArrayBufferin Firefox and Chrome. But lib.dom always said it was anArrayBuffer, so TypeScript narrowedinstanceof SharedArrayBufferchecks tonever.Now,
Memoryis generic over its buffer type. Regular memories still getArrayBuffer, while shared ones getArrayBufferLike. I didn't nameSharedArrayBufferdirectly so lib.dom still compiles on ES5/ES6 targets (as required). The default isArrayBufferLike, just like with typed arrays, so existing code keeps working.toFixedLengthBuffer()andtoResizableBuffer()now follow the same type.I've added a unit test that fails without this change, and
npm testpasses.