Skip to content

Unify nodeKind implementations for navigationBar and navigateTo#9984

Merged
3 commits merged into
masterfrom
node_kind
Jul 29, 2016
Merged

Unify nodeKind implementations for navigationBar and navigateTo#9984
3 commits merged into
masterfrom
node_kind

Conversation

@ghost

@ghost ghost commented Jul 27, 2016

Copy link
Copy Markdown

Fixes #9145

Comment thread src/services/services.ts Outdated
}
return ScriptElementKind.unknown;

function variableDeclarationKind(v: VariableDeclaration): string {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better name is getKindOfVariableDeclaration? Up to you.

@sandersn

Copy link
Copy Markdown
Member

👍

@ghost ghost merged commit c696030 into master Jul 29, 2016
@ghost ghost deleted the node_kind branch July 29, 2016 15:19
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants