Treat "." and ".." as relative module names#9676
Merged
5 commits merged intoJul 13, 2016
Merged
Conversation
| export function isExternalModuleNameRelative(moduleName: string): boolean { | ||
| // TypeScript 1.0 spec (April 2014): 11.2.1 | ||
| // An external module name is "relative" if the first term is "." or "..". | ||
| return moduleName.substr(0, 2) === "./" || moduleName.substr(0, 3) === "../" || moduleName.substr(0, 2) === ".\\" || moduleName.substr(0, 3) === "..\\"; |
Member
There was a problem hiding this comment.
why not use /^\.\.?($|[\\/])/.test(moduleName)? It's a regex, but I think it's still easier to read than 16 lines of imperative code.
Member
|
👍 |
ghost
Author
|
One more 8e679b7 |
| } | ||
|
|
||
| // Should act like String.prototype.startsWith | ||
| export function stringStartsWith(s: string, start: string): boolean { |
Contributor
There was a problem hiding this comment.
we already have startsWith and endsWith in utilities.ts. BTW. this function seems to be unused
added 2 commits
July 13, 2016 11:26
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9651