Skip to content

Fix #6319: Add support for --t: es5 and --m es6#9042

Merged
mhegazy merged 7 commits into
masterfrom
ES6ModulesES5Target
Jun 10, 2016
Merged

Fix #6319: Add support for --t: es5 and --m es6#9042
mhegazy merged 7 commits into
masterfrom
ES6ModulesES5Target

Conversation

@mhegazy

@mhegazy mhegazy commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

Fixes #6319.

@@ -0,0 +1,12 @@
=== tests/cases/compiler/es6modulekindWithES5Target9.ts ===

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code here looks different from tests/baselines/reference/es6modulekindWithES5Target9.js ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. earlier files that i have used and did not delete.

import {a} from "mod";

import * as M from "mod";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add usage of d, a, M etc to verify exports.identifier is not being emitted

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mhegazy

mhegazy commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

@sheetalkamat any more comments?

@sheetalkamat

Copy link
Copy Markdown
Member

👍

@texastoland

Copy link
Copy Markdown
Contributor

CC @Victorystick!

@Victorystick

Copy link
Copy Markdown

Woop! This is fantastic news! 🎉 In which stable version can we expect to see these changes?

@mariusschulz

Copy link
Copy Markdown
Contributor

Yey, great to see this feature! 🎉

@Victorystick The roadmap lists it underneath 2.0.

@texastoland

Copy link
Copy Markdown
Contributor

It was merged into master so I assume 1.9 though and testable in nightly 1.9.0-dev.20160610-1.0?

@mhegazy

mhegazy commented Jun 11, 2016

Copy link
Copy Markdown
Contributor Author

correct. today's build should have the fix. it should be shipped as part of the next release (TS 2.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants