Fix RWC Runner. Only check if extensions property match support extensions specified in tsconfig#8870
Merged
Conversation
Member
|
What's the context behind this change? I see that it now does not check |
Contributor
Author
|
@sandersn we made a change in our compiler to always include "outdir" in "exclude". However, when we captured RWC, we record directories in used and its exclude property doesn't account for the new behavior. Unless we recapture, it block some tests to be run. One question I have is why do we check it in the first place @RyanCavanaugh may know. |
Contributor
|
👍 |
Contributor
Author
|
talk with @mhegazy offline, the arguments won't make any different |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.