Skip to content

Lint all servicesSources#8810

Merged
1 commit merged into
masterfrom
lint_more_more
May 25, 2016
Merged

Lint all servicesSources#8810
1 commit merged into
masterfrom
lint_more_more

Conversation

@ghost

@ghost ghost commented May 25, 2016

Copy link
Copy Markdown

No description provided.

@ghost ghost assigned sandersn May 25, 2016
@msftclas

msftclas commented May 25, 2016

Copy link
Copy Markdown

Hi @Andy-MS, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Andy Hanson). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

sandersn
sandersn reviewed May 25, 2016
View reviewed changes
Comment thread src/services/formatting/ruleOperation.ts
@@ -1,4 +1,5 @@
///<reference path='references.ts' />
/* tslint:disable:no-null-keyword */

@sandersn sandersn May 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Is this the only file that uses null? I wonder if it was intentional. Does it work if you switch to undefined? Ron or Vlad might also be able to tell you if the usage was intentional.

@sandersn sandersn May 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I got to the more extensive uses of null below. Still might be worth asking around to see if you can learn the reason for null usage here and nowhere else.

@sandersn

sandersn commented May 25, 2016

Copy link
Copy Markdown
Member

👍 although it would be nice to know why services uses null, especially in undefined-accepting constructions like == null

@ghost ghost mentioned this pull request May 25, 2016
Closed
@ghost ghost merged commit d7e30f0 into master May 25, 2016
@ghost ghost deleted the lint_more_more branch May 25, 2016 15:10
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@sandersn sandersn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msftclas @sandersn