do not emit double assignment of class expressions.#8786
Merged
Conversation
|
Hi @rkirov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Contributor
|
👍 |
Contributor
|
@rbuckton can you take a look. |
Contributor
|
looks like the linter is complaining:
|
| // export class C { | export let C = C_1 = class C { | ||
| // static x() { return C.y; } | static x() { return C_1.y; } | ||
| // static y = 1; | } | ||
| // @dec | let C = C_1 = class C { |
Contributor
There was a problem hiding this comment.
extra C = in the comment.
Closure compiler ES6 support rejects expressions of the form `let A = B
= class {}`
With a small rewriting of the emitted code the case of decorated and
staticly referenced classes, TypeScript ES6 emit satisfies this
requirement.
Before:
let C_1;
let C = C_1 = class C {};
After:
let C_1 = class C {};
let C_1 = C;
rkirov
force-pushed
the
no_double_assignment
branch
from
10f71a8 to
699dc4f
Compare
Contributor
Author
|
took care of the comments. PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closure compiler ES6 support rejects expressions of the form
let A = B = class {}With a small rewriting of the emitted code the case of decorated and
statically referenced classes, TypeScript ES6 emit satisfies this
requirement.
Before:
let C_1;
let C = C_1 = class C {};
After:
let C_1 = class C {};
let C = C_1;